Thread (18 messages) 18 messages, 2 authors, 2017-06-16

[PATCH v3 1/9] gpio: mvebu: fix regmap_update_bits usage

From: Linus Walleij <hidden>
Date: 2017-06-16 09:18:42
Also in: linux-devicetree, linux-gpio, lkml

On Mon, Jun 12, 2017 at 5:34 PM, Gregory CLEMENT
[off-list ref] wrote:
In some place in the driver regmap_update_bits was misused. Indeed the
last argument is not the value of the bit (or group of bits) itself but
the mask value inside the register.

So when setting the bit N, then the value must be BIT(N) and not 1.

CC: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
CC: Ralph Sennhauser <redacted>
Reviewed-by: Thomas Petazzoni <redacted>
Tested-by: Ralph Sennhauser <redacted>
Tested-by: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Signed-off-by: Gregory CLEMENT <redacted>
Already applied this patch, sorry for missing the resend in the series.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help