Thread (7 messages) 7 messages, 4 authors, 2017-06-19

[PATCH V2 2/2] timer: imx-tpm: add imx tpm timer support

From: Alexander Stein <hidden>
Date: 2017-06-13 08:19:56
Also in: lkml

On Tuesday 13 June 2017 15:58:45, Dong Aisheng wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/clocksource/timer-imx-tpm.c
b/drivers/clocksource/timer-imx-tpm.c new file mode 100644
index 0000000..940a4f75
--- /dev/null
+++ b/drivers/clocksource/timer-imx-tpm.c
@@ -0,0 +1,227 @@
[...]
+static int tpm_set_next_event(unsigned long delta,
+				struct clock_event_device *evt)
+{
+	unsigned long next, now;
+
+	next = readl(timer_base + TPM_CNT) + delta;
+	writel(next, timer_base + TPM_C0V);
+	now = readl(timer_base + TPM_CNT);
What about:
now = readl(timer_base + TPM_CNT);
next = now + delta;
writel(next, timer_base + TPM_C0V);
return 0;
+	return (int)((next - now) <= 0) ? -ETIME : 0;
Can this error actually happen, even with your implementation?

Best regards,
Alexander
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help