Thread (17 messages) 17 messages, 5 authors, 2017-06-13

[PATCH] tty: serial: lpuart: fix semicolon.cocci warnings

From: Dong Aisheng <hidden>
Date: 2017-06-13 02:38:10
Also in: linux-serial, lkml
Subsystem: the rest, tty layer and serial drivers · Maintainers: Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby

Hi Fengguang,

On Tue, Jun 13, 2017 at 08:28:41AM +0800, kbuild test robot wrote:
drivers/tty/serial/fsl_lpuart.c:305:2-3: Unneeded semicolon


 Remove unneeded semicolon.

Generated by: scripts/coccinelle/misc/semicolon.cocci

CC: Dong Aisheng <aisheng.dong@nxp.com>
Signed-off-by: Fengguang Wu <redacted>
Seems not catched by checkpatch.
quoted hunk ↗ jump to hunk
---

 fsl_lpuart.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -302,7 +302,7 @@ static inline void lpuart32_write(struct
 	case UPIO_MEM32BE:
 		iowrite32be(val, port->membase + off);
 		break;
-	};
+	}
lpuart32_read needs the same fixing.
diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index a66ed23..ed0bf18 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -288,7 +288,7 @@ static inline u32 lpuart32_read(struct uart_port *port, u32 off)
                return ioread32be(port->membase + off);
        default:
                return 0;
-       };
+       }
 }
 
 static inline void lpuart32_write(struct uart_port *port, u32 val,
@@ -301,7 +301,7 @@ static inline void lpuart32_write(struct uart_port *port, u32 val,
        case UPIO_MEM32BE:
                iowrite32be(val, port->membase + off);
                break;
-       };
+       }
 }
Thanks for the catching.

Regards
Dong Aisheng
 }
 
 static void lpuart_stop_tx(struct uart_port *port)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help