[PATCH v5 2/3] PCI: Add tango PCIe host bridge support
From: Marc Gonzalez <hidden>
Date: 2017-06-07 08:26:18
Also in:
linux-pci, lkml
From: Marc Gonzalez <hidden>
Date: 2017-06-07 08:26:18
Also in:
linux-pci, lkml
On 31/05/2017 15:33, Marc Gonzalez wrote:
+static int tango_pcie_probe(struct platform_device *pdev)
+{
+ int ret = -EINVAL;
+ void __iomem *base;
+ struct resource *res;
+ struct tango_pcie *pcie;
+ struct device *dev = &pdev->dev;
+
+ pr_err("MAJOR ISSUE: PCIe config and mem spaces are muxed\n");
+ pr_err("Tainting kernel... Use driver at your own risk\n");
+ add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);Hello Bjorn, In v4, your only comment was "[muxing config and mem spaces] is a major issue and possibly even a security problem [which requires at least an error message and a kernel taint]. Were there any other issues with the host bridge support? Or is the HW quirk/bug too severe to mainline the driver? (I would hate having to discard all that work though.) Regards.