On 6 June 2017 at 05:21, Rafa? Mi?ecki [off-list ref] wrote:

On 2017-06-05 23:09, Markus Mayer wrote:

quoted

--- /dev/null
+++ b/Documentation/devicetree/bindings/thermal/brcm,avs-tmon.txt

@@ -0,0 +1,20 @@
+* Broadcom STB thermal management
+
+Thermal management core, provided by the AVS TMON hardware block.
+
+Required properties:
+- compatible: must be one of "brcm,avs-tmon" or "brcm,avs-tmon-bcm7445"

Is the "one of" correct here? I'm not native English but it sounds like
setting both is a wrong thing.

You are right. It should not say "one of". I'll fix the wording.

quoted

+- reg: address range for the AVS TMON registers
+- interrupts: temperature monitor interrupt, for high/low threshold
triggers
+- interrupt-names: should be "tmon"
+- interrupt-parent: the parent interrupt controller
+
+Example:
+
+       thermal at f04d1500 {
+               compatible = "brcm,avs-tmon-bcm7445", "brcm,avs-tmon";

Yet here you use both bindings.