[PATCH] ARM: s3c64xx: don't select ARM_AMBA from S3C64XX_PL080

On 31 May 2017 at 14:25, Arnd Bergmann [off-list ref] wrote:

On Wed, May 31, 2017 at 9:58 PM, Russell King - ARM Linux
[off-list ref] wrote:

quoted

On Wed, May 24, 2017 at 05:58:34PM +0200, Arnd Bergmann wrote:
Yes, selecting ARM_AMBA from drivers is definitely not right; this
symbol should be selected only by platforms that want AMBA primecell
bus support, not by drivers, precisely because of these dependency
issues.

There's another case where ARM_AMBA is selected that probably needs
fixing - the coresight hwtracing code.

[Adding Mathieu to cc]

Mathieu,

do you remember how we ended up with this?

That was part of the initial driver submission that happened a couple
of years ago.  The driver depended on AMBA and as such I added the
"select", not knowing it was preferable to have a "depends".

menuconfig CORESIGHT
       bool "CoreSight Tracing Support"
       select ARM_AMBA

As Russell says, probably shouldn't select that symbol, most likely
we want either the individual drivers that register an amba_driver to have
a 'depends on ARM_AMBA' or alternatively replace the 'select' with 'depends
on' for the entire subsystem.

I'm good with that.

Mathieu

        Arnd