Thread (1 message) 1 message, 1 author, 2017-05-30

[PATCH v4 2/2] hwmon: (scpi) Fix the scale of SCP sensor readings

From: Sudeep Holla <hidden>
Date: 2017-05-30 11:14:44
Also in: linux-amlogic, linux-devicetree, linux-hwmon


On 30/05/17 10:05, Carlo Caione wrote:
From: Carlo Caione <redacted>

The implementation details for SCPI seems to suggest that the sensor
readings must be reported by SCP using a well defined scale
(millidegree Celsius for temperature, millivolts for voltage,
milliamperes for current, microwatts for power and microjoules for
energy).

This is also important for the interaction with other subsystems: for
example both the thermal sub-system and the hwmon sysfs interface expect
the temperature expressed in millidegree Celsius.

Unfortunately since this behaviour is dependent on the firmware
implementation there are cases where the sensor readings are reported
using a different scale. For example in the Amlogic SoCs the
temperature is reported in degree and not millidegree Celsius.

To take into account this discrepancy and fixup the values reported by
SCP a new compatible 'amlogic,meson-gxbb-scpi-sensors' is introduced and
used in this patch by the scpi-hwmon driver to convert the sensor
readings to the expected scale.
Looks good to me

Acked-by: Sudeep Holla <redacted>

-- 
Regards,
Sudeep
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help