Thread (5 messages) 5 messages, 4 authors, 2017-05-30

[PATCH] spi: add null check before pointer dereference

From: Gustavo A. R. Silva <hidden>
Date: 2017-05-30 02:33:22
Also in: linux-samsung-soc, linux-spi, lkml

Hi Andi,

Quoting Andi Shyti [off-list ref]:
Hi Gustavo,
quoted
 	desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents,
 				       dma->direction, DMA_PREP_INTERRUPT);

+	if (!desc) {
+		dev_err(&sdd->master->dev,
+			"%s:dmaengine_prep_slave_sg Failed\n", __func__);
+		return;
+	}
+
I'm sorry, I would nack this patch for now. There was a smilar I
sent before, but, as Krzysztof said, this needs more testing and
a proper solution.
Yeah, I get it.
That's anyway in my todo list.
That's great.
Thanks,
Andi
Thanks!
--
Gustavo A. R. Silva
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help