[PATCH 02/15] iio: dac: stm32: use devm_of_platform_populate()
From: Fabrice Gasnier <hidden>
Date: 2017-05-29 16:10:47
Also in:
linux-iio, lkml
On 05/29/2017 05:45 PM, Benjamin Gaignard wrote:
quoted hunk ↗ jump to hunk
Use devm_of_platform_populate() instead of of_platform_populate and of_platform_depopulate to simplify driver code Signed-off-by: Benjamin Gaignard <redacted> CC: Jonathan Cameron <jic23@kernel.org> CC: Hartmut Knaack <redacted> CC: Lars-Peter Clausen <lars@metafoo.de> CC: Alexandre Torgue <redacted> CC: Fabrice Gasnier <redacted> CC: linux-iio at vger.kernel.org CC: linux-arm-kernel at lists.infradead.org CC: linux-kernel at vger.kernel.org --- drivers/iio/dac/stm32-dac-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)diff --git a/drivers/iio/dac/stm32-dac-core.c b/drivers/iio/dac/stm32-dac-core.c index 75e4878..9c42537 100644 --- a/drivers/iio/dac/stm32-dac-core.c +++ b/drivers/iio/dac/stm32-dac-core.c@@ -130,7 +130,7 @@ static int stm32_dac_probe(struct platform_device *pdev) platform_set_drvdata(pdev, &priv->common); - ret = of_platform_populate(pdev->dev.of_node, NULL, NULL, dev); + ret = devm_of_platform_populate(&pdev->dev); if (ret < 0) { dev_err(dev, "failed to populate DT children\n"); goto err_pclk;@@ -151,7 +151,6 @@ static int stm32_dac_remove(struct platform_device *pdev) struct stm32_dac_common *common = platform_get_drvdata(pdev); struct stm32_dac_priv *priv = to_stm32_dac_priv(common); - of_platform_depopulate(&pdev->dev);
Hi Benjamin, Same as patch 1, This is going to change order of sub devices removal. It may end-up with bellow resources being removed while sub-device still needs them. Not sure this is a good candidate for such a change. Best Regards, Fabrice
clk_disable_unprepare(priv->pclk); regulator_disable(priv->vref);