On 2017? 05? 23? 18:43, Chanwoo Choi wrote:

Hi Arvind,

On 2017? 05? 19? 19:50, Arvind Yadav wrote:

quoted

clk_prepare_enable() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <redacted>
---
 drivers/devfreq/event/exynos-nocp.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/devfreq/event/exynos-nocp.c b/drivers/devfreq/event/exynos-nocp.c
index 5c3e7b1..f6e7956 100644
--- a/drivers/devfreq/event/exynos-nocp.c
+++ b/drivers/devfreq/event/exynos-nocp.c

@@ -267,7 +267,11 @@ static int exynos_nocp_probe(struct platform_device *pdev)
 	}
 	platform_set_drvdata(pdev, nocp);
 
-	clk_prepare_enable(nocp->clk);
+	ret = clk_prepare_enable(nocp->clk);
+	if (ret) {
+		dev_err(&pdev->dev, "failed to prepare ppmu clock\n");
+		return ret;
+	}

I already replied from the similar patch. Thanks.

quoted

 
 	pr_info("exynos-nocp: new NoC Probe device registered: %s\n",
 			dev_name(dev));

I'm missing some point that if there is no clock
this driver initializes 'nocp->clk = NULL;' on 217 line.

Looks good to me.
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics