Thread (14 messages) 14 messages, 5 authors, 2017-05-23

[PATCH v2 8/9] crypto: mediatek - Use IPAD/OPAD constant

From: matthias.bgg@gmail.com (Matthias Brugger)
Date: 2017-05-19 09:11:15
Also in: linux-crypto, linux-mediatek, lkml


On 19/05/17 08:53, Corentin Labbe wrote:
This patch simply replace all occurrence of HMAC IPAD/OPAD value by their
define.

Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
---
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
quoted hunk ↗ jump to hunk
  drivers/crypto/mediatek/mtk-sha.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/mediatek/mtk-sha.c b/drivers/crypto/mediatek/mtk-sha.c
index 2226f12d1c7a..5f4f845adbb8 100644
--- a/drivers/crypto/mediatek/mtk-sha.c
+++ b/drivers/crypto/mediatek/mtk-sha.c
@@ -12,6 +12,7 @@
   * Some ideas are from atmel-sha.c and omap-sham.c drivers.
   */
  
+#include <crypto/hmac.h>
  #include <crypto/sha.h>
  #include "mtk-platform.h"
  
@@ -825,8 +826,8 @@ static int mtk_sha_setkey(struct crypto_ahash *tfm, const u8 *key,
  	memcpy(bctx->opad, bctx->ipad, bs);
  
  	for (i = 0; i < bs; i++) {
-		bctx->ipad[i] ^= 0x36;
-		bctx->opad[i] ^= 0x5c;
+		bctx->ipad[i] ^= HMAC_IPAD_VALUE;
+		bctx->opad[i] ^= HMAC_OPAD_VALUE;
  	}
  
  	return 0;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help