[V2, 2/6] tty: serial: lpuart: add little endian 32 bit register support
From: Dong Aisheng <hidden>
Date: 2017-05-17 03:31:40
Also in:
linux-serial, lkml
From: Dong Aisheng <hidden>
Date: 2017-05-17 03:31:40
Also in:
linux-serial, lkml
On Tue, May 16, 2017 at 02:08:12PM +0300, Nikita Yushchenko wrote:
quoted
@@ -2000,6 +2007,7 @@ static int lpuart_probe(struct platform_device *pdev) } sport->port.line = ret; sport->lpuart32 = sdata->is_32; + lpuart_is_be = sdata->is_be;Setting a global variable in per-device routine is quite bad design.
There is a reason for that we don't want to change the exist lpuart32_read[write] API which is widely used in driver. Making a global lpuart_is_be is the simplest way to do it. Any strong blocking reason? Regards Dong Aisheng