On Mon, May 15, 2017 at 6:43 PM, Mark Rutland [off-list ref] wrote:

Hi,

On Mon, May 15, 2017 at 05:32:14PM +0530, Anup Patel wrote:

quoted

+/ {
+     chosen { /* Default kernel args */
+             bootargs = "root=/dev/ram rw rootwait \
+                         earlycon=uart8250,mmio32,0x68a10000 \
+                         pci=pcie_bus_safe cma=64M";

Why do we need all of these?

Yes, we don't need bootargs here. This were just for reference.

I will remove default bootargs because its responsibility of
bootloader to add it.

quoted

+             linux,stdout-path = "serial0:115200n8";

Please drop the 'linux,' prefix here.

Sure, will do.

[...]

quoted

+     memory: memory at 80000000 {
+             device_type = "memory";
+             reg = <0x00000000 0x80000000 0 0x40000000>;
+     };
+
+     psci {
+             compatible = "arm,psci-0.2";
+             method = "smc";
+     };
+
+     pmu {
+             compatible = "arm,armv8-pmuv3";
+             interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_HIGH>;
+     };
+
+     timer {
+             compatible = "arm,armv8-timer";
+             interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) |
+                           IRQ_TYPE_LEVEL_LOW)>,
+                          <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) |
+                           IRQ_TYPE_LEVEL_LOW)>,
+                          <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) |
+                           IRQ_TYPE_LEVEL_LOW)>,
+                          <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) |
+                           IRQ_TYPE_LEVEL_LOW)>;

GICv3 PPIs don't have a mask. See

Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt

Please remove the GIC_CPU_MASK_*() uses here and in this dts. They
shouldn't be there.

Thanks for catching.

We had taken care of this in PMU DT node but did not cleanup timer
DT node.

Thanks,
Anup