Thread (37 messages) 37 messages, 3 authors, 2017-05-09

[linux-sunxi] [PATCH v6 11/13] ARM: dts: sun8i: add DE2 nodes for V3s SoC

From: Maxime Ripard <hidden>
Date: 2017-05-09 19:26:16
Also in: dri-devel, linux-clk, linux-devicetree, lkml

1;4601;0c
On Fri, May 05, 2017 at 08:34:16PM +0800, Icenowy Zheng wrote:

? 2017?5?5? GMT+08:00 ??8:30:35, Maxime Ripard [off-list ref] ??:
quoted
On Fri, May 05, 2017 at 04:53:43PM +0800, icenowy at aosc.io wrote:
quoted
quoted
quoted
+               de2_clocks: clock at 1000000 {
+                       compatible =
"allwinner,sun50i-h5-de2-clk";
quoted
quoted
I am a bit skeptical about this. Since the V3S only has one mixer,
do
quoted
quoted
the clocks
for the second one even exist?
It's described in the de_clock.c in the BSP source code, and in
hardware
quoted
these bits can be really set (although without clock output).

So I use this compatible which has still the extra clocks.
If it's not usable, then it shouldn't be in the code, it's basically
dead code.
Thus should we have one more DE2 CCU compatible without mixer1
clocks for V3s?
If those clocks don't exist on v3s, then yes.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170509/dd115812/attachment.sig>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help