On Mon, May 01, 2017 at 10:28:46PM +0800, Chen-Yu Tsai wrote:

On Mon, May 1, 2017 at 10:01 PM, Andrew Lunn [off-list ref] wrote:

quoted

On Mon, May 01, 2017 at 02:45:00PM +0200, Corentin Labbe wrote:

quoted

Hello

This patch series add the driver for dwmac-sun8i which handle the Ethernet MAC
present on Allwinner H3/H5/A83T/A64 SoCs.

This driver is the continuation of the sun8i-emac driver.
During the development, it appeared that in fact the hardware was a modified
version of some dwmac.
So the driver is now written as a glue driver for stmmac.

It supports 10/100/1000 Mbit/s speed with half/full duplex.
It can use an internal PHY (MII 10/100) or an external PHY
via RGMII/RMII.

Hi Corentin

Sorry if this has been asked before....

Does the internal PHY have a phy driver? It seems like
tx-delay-ps/rx-delay-ps are properties of this internal PHY, and so
should be in the phy driver, if it has one.

Nope. These affect the delay lines for the external PHY interface.

Oh, yes. I understood the patch wrong.

None of the patches actually use these properties. Are they actually
needed? We should avoid adding vendor specific properties, if they are
not used.

    Andrew