[PATCH v2 5/5] iommu: Allow default domain type to be set on the kernel command line

On Tue, Mar 21, 2017 at 05:21:37PM +0000, Will Deacon wrote:

On Tue, Mar 21, 2017 at 04:45:27PM +0100, Joerg Roedel wrote:

quoted

On Fri, Mar 10, 2017 at 08:49:36PM +0000, Will Deacon wrote:

quoted

@@ -1014,8 +1027,8 @@ struct iommu_group *iommu_group_get_for_dev(struct device *dev)
 	 * IOMMU driver.
 	 */
 	if (!group->default_domain) {
-		group->default_domain = __iommu_domain_alloc(dev->bus,
-							     IOMMU_DOMAIN_DMA);
+		group->default_domain =
+			__iommu_domain_alloc(dev->bus, iommu_def_domain_type);

It would be good to have a fall-back here if we are talking to an IOMMU
driver that uses default domains, but does not support identity-mapped
domains (yet). Exynos and Rockchip IOMMU drivers seem to fall into this
category. A dev_warn() also makes sense in case allocating a identity
domain fails.

Sure, something like the diff below?

Yes, this looks good.


Thanks,

	Joerg