[PATCH V9 00/11] IOMMU probe deferral support
From: Lorenzo Pieralisi <hidden>
Date: 2017-03-24 14:43:40
Also in:
linux-acpi, linux-arm-msm, linux-iommu, linux-pci
Possibly related (same subject, not in this thread)
- 2017-03-28 · Re: [PATCH V9 00/11] IOMMU probe deferral support · Sricharan R <hidden>
- 2017-03-28 · RE: [PATCH V9 00/11] IOMMU probe deferral support · Shameerali Kolothum Thodi <hidden>
- 2017-03-28 · Re: [PATCH V9 00/11] IOMMU probe deferral support · Sricharan R <hidden>
- 2017-03-27 · Re: [PATCH V9 00/11] IOMMU probe deferral support · Lorenzo Pieralisi <hidden>
- 2017-03-24 · Re: [PATCH V9 00/11] IOMMU probe deferral support · Sricharan R <hidden>
On Fri, Mar 24, 2017 at 09:27:51AM +0000, Shameerali Kolothum Thodi wrote: [...]
quoted hunk ↗ jump to hunk
@@ -107,7 +107,7 @@ int of_dma_configure(struct device *dev, struct device_node *np) ret = of_dma_get_range(np, &dma_addr, &paddr, &size); if (ret < 0) { dma_addr = offset = 0; - size = dev->coherent_dma_mask + 1; + size = max(dev->coherent_dma_mask, dev->coherent_dma_mask + 1);@@ -1386,7 +1387,8 @@ int acpi_dma_configure(struct device *dev, enum dev_dma_attr attr) * Assume dma valid range starts at 0 and covers the whole * coherent_dma_mask. */ - arch_setup_dma_ops(dev, 0, dev->coherent_dma_mask + 1, iommu, + size = max(dev->coherent_dma_mask, dev->coherent_dma_mask + 1);
size is not defined in acpi_dma_configure(), so there is something missing in the diff above, just to make sure we are testing the same thing. Mind posting kernel logs with and without patch above (fixed) for DT boot and ACPI boot please. Thanks, Lorenzo
+ arch_setup_dma_ops(dev, 0, size, iommu, attr == DEV_DMA_COHERENT); With the above fixes, DT boot works fine. But we still get the below crash on ACPIquoted
quoted
[ 402.581445] kernel BUG at drivers/iommu/arm-smmu-v3.c:1064! [ 402.587007] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP [ 402.592479] Modules linked in: vfio_iommu_type1 vfio_pci irqbypassvfio_virqfd vfio ixgbevf ixgbquoted
The change that this series does is trying to add the dma/iommu ops to the device after the iommu is actually probed. So in your working case, does the device initially gets hooked to iommu_ops and the above same check passes in working case ?I believe so. Because didn't notice the "specified DMA range outside IOMMU capability" in the working case. Thanks, Shameer