On 29/03/17 09:37, Vincent Guittot wrote:

On 27 March 2017 at 15:18, Juri Lelli [off-list ref] wrote:

quoted

parse_cpu_capacity() has to return 0 on failure, but it currently returns
1 instead if raw_capacity kcalloc failed.

Fix it by removing the negation of the return value.

Cc: Russell King <redacted>
Reported-by: Morten Rasmussen <redacted>
Fixes: 06073ee26775 ('ARM: 8621/3: parse cpu capacity-dmips-mhz from DT')
Signed-off-by: Juri Lelli <redacted>
---
 arch/arm/kernel/topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
index f8a3ab82e77f..4e4af809606a 100644
--- a/arch/arm/kernel/topology.c
+++ b/arch/arm/kernel/topology.c

@@ -166,7 +166,7 @@ static int __init parse_cpu_capacity(struct device_node *cpu_node, int cpu)
                        if (!raw_capacity) {
                                pr_err("cpu_capacity: failed to allocate memory for raw capacities\n");
                                cap_parsing_failed = true;
-                               return !ret;
+                               return ret;

Why not directly returning 0 ? whatever the value of ret, the parse of
cpu capacity has failed in this case

Sure, can change that.

Thanks,

- Juri