Thread (11 messages) 11 messages, 2 authors, 2017-03-27

[PATCH v3 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan

From: Ralph Sennhauser <hidden>
Date: 2017-03-26 21:06:23
Also in: linux-devicetree, linux-gpio, linux-pwm, lkml

On Fri, 24 Mar 2017 15:35:05 +0100
Andrew Lunn [off-list ref] wrote:
quoted
+	pwm_fan {
 		/* SUNON HA4010V4-0000-C99 */
-		compatible = "gpio-fan";
-		gpios = <&gpio0 24 0>;
 
-		gpio-fan,speed-map = <0    0
-				      4500 1>;
+		compatible = "pwm-fan";
+		pwms = <&gpio0 24 4000 0>;  
Hi Ralph

I believe this last 0 is the flags parameter. Now that we have
#pwm-cells = 1, i think this last 0 should be dropped.

	  Andrew
Hi Andrew,

isn't the 4000 (period?) pwm-cell #2 and 0 (flags?) pwm-cell #3? I
actually expect "pwms = <&gpio0 24>;" here or "#pwm-cells = <2>;"

Ralph
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help