Thread (6 messages) 6 messages, 3 authors, 2017-03-28

[PATCH] ACPI / IPMI: change warning to debug on timeout

From: Corey Minyard <hidden>
Date: 2017-03-25 02:55:17
Also in: linux-acpi, linux-arm-msm, lkml

Why would a timeout for a message be expected?  The BMC should
at least respond with an error for an incorrect message.

-corey

On 03/23/2017 10:32 AM, Sinan Kaya wrote:
quoted hunk ↗ jump to hunk
Getting timeout message from BMC when trying to read from a non-existent
FRU. This is expected but warning is not.

Let's reduce the warning to debug.

Signed-off-by: Sinan Kaya <redacted>
---
  drivers/acpi/acpi_ipmi.c | 3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/acpi/acpi_ipmi.c b/drivers/acpi/acpi_ipmi.c
index 747c2ba..1b64419 100644
--- a/drivers/acpi/acpi_ipmi.c
+++ b/drivers/acpi/acpi_ipmi.c
@@ -429,8 +429,7 @@ static void ipmi_msg_handler(struct ipmi_recv_msg *msg, void *user_msg_data)
  	if (msg->recv_type == IPMI_RESPONSE_RECV_TYPE &&
  	    msg->msg.data_len == 1) {
  		if (msg->msg.data[0] == IPMI_TIMEOUT_COMPLETION_CODE) {
-			dev_WARN_ONCE(dev, true,
-				      "Unexpected response (timeout).\n");
+			dev_dbg_once(dev, "Unexpected response (timeout).\n");
  			tx_msg->msg_done = ACPI_IPMI_TIMEOUT;
  		}
  		goto out_comp;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help