Thread (15 messages) 15 messages, 5 authors, 2017-03-14

[PATCH v2 4/6] bus: add driver for the Technologic Systems NBUS

From: Linus Walleij <hidden>
Date: 2017-03-14 13:24:23
Also in: linux-devicetree, linux-watchdog, lkml

On Wed, Feb 22, 2017 at 5:56 PM, Sebastien Bourdelin
[off-list ref] wrote:
On 02/04/2017 05:14 AM, Linus Walleij wrote:
quoted
quoted
+       gpiod_set_array_value_cansleep(gpios->ndescs, gpios->desc, values);
This can also fail and you should check the return code and print an error
message if it does.
As far as i understood, the "gpiod_set_array_value_cansleep(...)"
function doesn't return
anything, it will return immediately if gpios->desc is null but nothing
else.
Did i miss something?
No I did, sorry about that.

We *should* make these functions return errors but currently they do not.
quoted
Error codes?
Same question here, these functions only make call to
"gpiod_set_value_cansleep(...)",
which as far as i understood doesn't return any error code.
Yeah, forget that.
quoted
quoted
+               gpiod_set_value_cansleep(ts_nbus->csn, 1);
Here too.
Same question, doesn't seem to have an error code.
That too.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help