Thread (7 messages) 7 messages, 3 authors, 2017-03-14

[PATCH 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler

flat view

From: Michal Simek <hidden>
Date: 2017-03-13 10:28:01
Also in: linux-devicetree, linux-fpga, lkml

Hi Moritz,

On 10.3.2017 23:42, Moritz Fischer wrote:
On Fri, Mar 10, 2017 at 1:30 PM, Moritz Fischer [off-list ref] wrote:
quoted
This adds support for the Xilinx LogiCORE PR Decoupler
soft-ip that does decoupling of PR regions in the FPGA
fabric during partial reconfiguration.

Signed-off-by: Moritz Fischer <mdf@kernel.org>
Cc: Michal Simek <redacted>
Cc: S?ren Brinkmann <redacted>
Cc: linux-kernel at vger.kernel.org
Cc: devicetree at vger.kernel.org
---
 drivers/fpga/Kconfig               |   9 +++
 drivers/fpga/Makefile              |   1 +
 drivers/fpga/xilinx-pr-decoupler.c | 156 +++++++++++++++++++++++++++++++++++++
 3 files changed, 166 insertions(+)
 create mode 100644 drivers/fpga/xilinx-pr-decoupler.c
I have written very similar driver some week ago but didn't sent it out.

Here it is.
https://github.com/Xilinx/linux-xlnx/blob/master/drivers/fpga/xilinx-pr-decoupler.c

Your clk handling is better and my enable_show is better.
You shouldn't rely on setting status before. It is better to read that
reg again. The reason is you can connect status signal from one PR
decoupler to decouple input which can change status

There is another topic I wanted to open in connection to this. There
should be gpio based bridge because this pr decoupler can be without axi
interface and for that gpio driver would be useful.

Thanks,
Michal
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help