Thread (49 messages) 49 messages, 4 authors, 2017-03-09

[PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

From: Joao Pinto <hidden>
Date: 2017-03-09 11:55:32
Also in: linux-devicetree, linux-omap, linux-pci, lkml

Hi Christoph,

?s 7:14 PM de 3/8/2017, Christoph Hellwig escreveu:
On Wed, Mar 08, 2017 at 03:32:03PM +0000, Joao Pinto wrote:
quoted
#define PCIE_GET_ATU_INB_UNR_REG_ADDR(region, register)		\
					((0x3 << 20) | (region << 9) |	\
					(0x1 << 8)
Can you turn this and any similar macro into inline functions?
Use an inline functions instead of macro is fine by me. In the initial patch I
implemented as a macro since it only does simple bit shifts and nothing else and
seemed simpler as a macro.

Thanks,
Joao
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help