On Fri, Mar 03, 2017 at 11:39:45AM +0000, John Keeping wrote:

This reset is required in order to fully reset the internal state of the
MIPI controller.

Signed-off-by: John Keeping <redacted>
---
On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote:

quoted

On Fri, Feb 24, 2017 at 12:55:06PM +0000, John Keeping wrote:

quoted

+	/*
+	 * Note that the reset was not defined in the initial device tree, so
+	 * we have to be prepared for it not being found.
+	 */
+	apb_rst = devm_reset_control_get(dev, "apb");  

Did this reset ever get documented in the device tree bindings? I
couldn't find it. Perhaps a follow-up patch is in order?

Here's a patch to do that.

FWIW:

Reviewed-by: Brian Norris <briannorris@chromium.org>

Thanks.