Thread (10 messages) flat view 10 messages, 6 authors, 2017-03-03

[PATCH] module: set __jump_table alignment to 8

From: jbaron@akamai.com (Jason Baron)
Date: 2017-03-02 15:36:09
Also in: linux-mips, linuxppc-dev, lkml

On 03/01/2017 05:04 PM, David Daney wrote:
For powerpc the __jump_table section in modules is not aligned, this
causes a WARN_ON() splat when loading a module containing a __jump_table.

Strict alignment became necessary with commit 3821fd35b58d
("jump_label: Reduce the size of struct static_key"), currently in
linux-next, which uses the two least significant bits of pointers to
__jump_table elements.

Fix by forcing __jump_table to 8, which is the same alignment used for
this section in the kernel proper.

Signed-off-by: David Daney <redacted>
Tested-by: Sachin Sant <redacted>
---
Looks good to me.

Reviewed-by: Jason Baron <jbaron@akamai.com>

Thanks,

-Jason
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help