On 20/02/2017 at 17:50:54 +0000, Russell King - ARM Linux wrote:

quoted

The question being what does that do and whether it could be done in the
driver instead.

It's not specific to the Armada 8040, the same problem exists with
Armada 38x, so holding this up for that reason does not make sense.

I agree, I will not delay the patch for that.

I suspect that the errata is "RTC is not reset at power up" for the RTC
power domain.

I don't know where the value of 0x2000 comes from for the correction
value, all I know is that's the value uboot uses with "date reset".
We probably do _not_ want the driver writing that each time the
kernel boots, since that's a tuning parameter.

It is probably a calibration offset. It may be worth exposing to
userspace but without more information, I doubt we can make something
useful out of it.



-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com