[linux-sunxi][PATCH] ARM: dts: sun8i-h3: orange-pi-2: Enable audio codec
From: Rask Ingemann Lambertsen <hidden>
Date: 2017-02-20 21:57:12
Also in:
linux-devicetree
On Mon, Feb 20, 2017 at 05:20:52PM +0100, codekipper at gmail.com wrote:
quoted hunk
From: Marcus Cooper <redacted> The Orange Pi 2 routes the LINEOUT pins through a SGM8900 PA which needs to be enabled. The onboard microphone is routed to MIC1, with MBIAS providing power. Signed-off-by: Marcus Cooper <redacted> --- arch/arm/boot/dts/sun8i-h3-orangepi-2.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts index 047e9e1c6093..b0d2b99990cc 100644 --- a/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-2.dts@@ -105,6 +105,16 @@ }; }; +&codec { + pinctrl-0 = <&codec_pa_pin>; + allwinner,pa-gpios = <&pio 0 16 GPIO_ACTIVE_HIGH>; /* PA16 */ + allwinner,audio-routing = + "Speaker", "LINEOUT", + "MIC1", "Mic", + "Mic", "MBIAS"; + status = "okay"; +}; + &ehci1 { status = "okay"; };@@ -144,6 +154,11 @@ }; &pio { + codec_pa_pin: codec_pa_pin at 0 { + pins = "PA16"; + function = "gpio_out"; + }; +
There should not be underscores in node names. See e.g.: https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1122967.html https://www.mail-archive.com/linux-kernel%40vger.kernel.org/msg1145633.html https://www.mail-archive.com/netdev%40vger.kernel.org/msg90319.html Pinmux nodes for GPIO usage are considered unnecessary or even harmful these days, so you should just drop the node in this case (as well as the reference to it). As a bonus, you avoid a duplicate definition. -- Rask Ingemann Lambertsen