On Friday, February 10, 2017 08:43:49 AM Viresh Kumar wrote:
On 09-02-17, 23:03, Rafael J. Wysocki wrote:
quoted
In particular, Viresh, if you ACK something, please make sure that it
doesn't conflict with your own patches.
I hope you are talking about the patch 3/4 for which Arnd also sent a
fix. I acked it back on 18th of January and Dave has been carrying my
Ack since then. When he posted again, I didn't went into reviewing it
again as I saw my Ack being there.
Well, OK, but you did know that the OPP API had changed in the meantime,
so it wouldn't have hurt to double check I suppose?
Yes, he ended up using an API which just got updated after 18th of Jan
and yes both me and Dave missed that. But I feel it is difficult to
take care of scenarios like this. Perhaps he should have made sure
that he base it of pm/linux-next and nothing would have gone wrong.
Yes, that would help, but then how to enforce that?
Thanks,
Rafael