Thread (23 messages) 23 messages, 6 authors, 2017-03-31

[PATCH 07/10] perf: Directly pass PERF_AUX_* flags to perf_aux_output_end

From: alexander.shishkin@linux.intel.com (Alexander Shishkin)
Date: 2017-02-17 14:11:21
Also in: lkml

Will Deacon [off-list ref] writes:
On Fri, Feb 17, 2017 at 03:40:23PM +0200, Alexander Shishkin wrote:
quoted
Will Deacon [off-list ref] writes:
quoted
@@ -485,7 +485,8 @@ int intel_bts_interrupt(void)
 		return handled;
 
 	perf_aux_output_end(&bts->handle, local_xchg(&buf->data_size, 0),
-			    !!local_xchg(&buf->lost, 0));
+			    local_xchg(&buf->lost, 0) ?
+			    PERF_AUX_FLAG_OVERWRITE : 0);
Heh, this one would have taken some time to debug. :)
Don't worry, this isn't a bug fix! This patch changes the prototype for
perf_aux_output_end so that it takes the flag instead of a "bool truncated"
parameter, so this is just fixing up the callers at the same time.
Yeah, I got that, what I'm saying is that the above should be
PERF_AUX_FLAG_TRUNCATED, not OVERWRITE. I only spotted it by accident.

Regards,
--
Alex
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help