Thread (30 messages) flat view 30 messages, 5 authors, 2017-02-15

[PATCH V8 08/10] ras: acpi / apei: generate trace event for unrecognized CPER section

From: rostedt@goodmis.org (Steven Rostedt)
Date: 2017-02-15 17:03:53
Also in: kvm, kvmarm, linux-acpi, linux-efi, lkml

On Wed, 15 Feb 2017 09:54:09 -0700
"Baicar, Tyler" [off-list ref] wrote:
\
In v9 I currently have this and the ARM trace event from this series 
both wrapped in an
ifdef verifying that CONFIG_RAS is enabled. This resolves the kbuild 
failures and
will have this code compiled out when that config isn't enabled. Do you 
think I
should use the ifdef or use these *_enabled() functions?
I believe you need both. The *_enabled() functions wont prevent build
errors. But since tracing is seldom enabled (usually only when you want
to see what's happening), the *_enabled() functions optimize the code
to not perform tasks that are only needed when tracing is enabled. When
I say "enabled" I mean actively tracing, as supposed to being just
enabled in the kernel.

-- Steve
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help