Thread (17 messages) 17 messages, 5 authors, 2017-02-20

[PATCH 3/5] devicetree: bindings: revise compatible string of sprd uart

From: robh+dt@kernel.org (Rob Herring)
Date: 2017-02-14 17:04:12
Also in: linux-devicetree, lkml

On Tue, Feb 14, 2017 at 3:19 AM, Chunyan Zhang
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
This patch revise the compatible string of sprd uart to "sc-uart"
since this driver is not only for SC9836, but for all Spreadtrum
SoCs so far.

Signed-off-by: Chunyan Zhang <redacted>
---
 Documentation/devicetree/bindings/serial/sprd-uart.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt
index 2aff0f2..9b0ad52 100644
--- a/Documentation/devicetree/bindings/serial/sprd-uart.txt
+++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt
@@ -1,7 +1,7 @@
 * Spreadtrum serial UART

 Required properties:
-- compatible: must be "sprd,sc9836-uart"
+- compatible: must be "sprd,sc-uart"
You can't just change compatible strings.

You don't need a generic-ish compatible if other SoCs have "the same"
uart. Then you just do: '"sprd,sc<new soc>-uart", "sprd,sc9836-uart"'
in the DT. The existing driver will work matching on sprd,sc9836-uart
and if you ever find some difference in the uarts you have the more
specific compatible string to handle that.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help