Thread (1 message) 1 message, 1 author, 2017-01-30
DORMANTno replies REVIEWED: 3 (3M)

1 review trailer.

[PATCH v2] mmc: meson-gx: set max block count

From: khilman@baylibre.com (Kevin Hilman)
Date: 2017-01-30 16:58:14
Also in: linux-amlogic

Heiner Kallweit [off-list ref] writes:
So far max_blk_count isn't set what results in a default of value 8
to be used (PAGE_SIZE / block size).
This describes the problem...
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- block length field has 9 bits, so set max_blk_count to 2^9-1 = 511
- in addition set max_req_size because max_blk_count is also limited
  by max_req_size / block_size
... and this part describes the fix, so should also be in the changelog.

with an updated changelog, feel free to add:

Acked-by: Kevin Hilman <khilman@baylibre.com>

Kevin
quoted hunk
---
 drivers/mmc/host/meson-gx-mmc.c | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 83361f1f..d4d174ed 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -810,6 +810,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
 		goto free_host;
 	}
 
+	mmc->max_blk_count = CMD_CFG_LENGTH_MASK;
+	mmc->max_req_size = mmc->max_blk_count * mmc->max_blk_size;
 	mmc->ops = &meson_mmc_ops;
 	mmc_add_host(mmc);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help