Thread (1 message) 1 message, 1 author, 2017-01-27
DORMANTno replies REVIEWED: 3 (3M)

1 review trailer.

[PATCH 2/3] mmc: meson-gx: minor improvements in meson_mmc_set_ios

From: khilman@baylibre.com (Kevin Hilman)
Date: 2017-01-27 17:43:45
Also in: linux-amlogic

Heiner Kallweit [off-list ref] writes:
val isn't used in the switch clause and afterwards there's an
identical statement. So remove it.

In case of an unexpected bus width the error message indicates
the intention to set the bus width to 4 and to go on.
So remove the return statement. This return statement also
conflicts with "setting to 4" because nothing would be set
actually before returning.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Kevin Hilman <khilman@baylibre.com>

Thanks for the fix,

Kevin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help