On 22 January 2017 at 11:25, Robert Jarzmik [off-list ref] wrote:

Robert Jarzmik [off-list ref] writes:

quoted

Ulf Hansson [off-list ref] writes:

quoted

On 20 January 2017 at 09:01, Robert Jarzmik [off-list ref] wrote:

quoted

Ulf Hansson [off-list ref] writes:
So I was wondering how you made the choice of which files you add the include to
and which you don't touch ?

By building the pxa_defconfig, see what errors it reports and then fix them.

Isn't pxa_defconfig building all the variants?

Euh actually it should, but it's not.

And actually thanks to a suggestion from Russell to improve my search line, I
came up with the command line bellow, and perhaps you could fix the others with
one command line and respin the patch ?

Here it is :

for f in $(grep -l _led arch/arm/mach-pxa/*.c | xargs grep -L linux/leds.h); do
sed -i '0,/^#include <linux\/[l-m].*>$/{s/\(#include <linux\/[l-m].*\)/#include
<linux\/leds.h>\n\1/}' $f; done

Cheers.

Robert, thanks for helping out!

While running the above command-line, the following files becomes changed:

arch/arm/mach-pxa/zylonite_pxa300.c
arch/arm/mach-pxa/zylonite_pxa320.c
arch/arm/mach-pxa/palmld.c
arch/arm/mach-pxa/palmtc.c
arch/arm/mach-pxa/ezx.c
arch/arm/mach-pxa/em-x270.c
arch/arm/mach-pxa/hx4700.c
arch/arm/mach-pxa/magician.c
arch/arm/mach-pxa/palmtreo.c
arch/arm/mach-pxa/corgi_pm.c
arch/arm/mach-pxa/spitz_pm.c
arch/arm/mach-pxa/tosa.c
arch/arm/mach-pxa/z2.c

However, already by building pxa_defconfig, I have verified that these
files are being build successfully without any changes needed.

Because of that, I am not sure I would like to make any additional
changes as a part of this series. I think it's easier if you later on
deal with that as clean-ups via your pxa tree instead, does that make
sense to you as well?

Kind regards
Uffe