Thread (4 messages) 4 messages, 3 authors, 2017-01-30

[PATCH V7 01/11] iommu/of: Refactor of_iommu_configure() for error handling

From: Sricharan <hidden>
Date: 2017-01-27 18:00:05
Also in: linux-acpi, linux-arm-msm, linux-iommu, linux-pci

Possibly related (same subject, not in this thread)

Hi Robin,

[..]
quoted
quoted
+const struct iommu_ops *of_iommu_configure(struct device *dev,
+                       struct device_node *master_np)
+{
+    const struct iommu_ops *ops;
+
+    if (!master_np)
+        return NULL;
+
+    if (dev_is_pci(dev))
+        ops = of_pci_iommu_init(to_pci_dev(dev), master_np);
I gave the whole patch set a try on ThunderX. really_probe() is failing
on dma_configure()->of_pci_iommu_init() for each PCI device.
When you say "failing", do you mean cleanly, or with a crash? I've
managed to hit __of_match_node() dereferencing NULL from
of_iommu_xlate() in a horribly complicated chain of events, which I'm
trying to figure out now, and I wonder if the two might be related.
Sorry that there is crash still. __of_match_node seems to checking
for NULL arguments , feels like some invalid pointer was passed in.
Is there any particular sequence to try for this ?

Regards,
 Sricharan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help