[PATCH v2 04/12] driver: clk: imx: Add clock driver for imx6sll
From: ping.bai@nxp.com (Jacky Bai)
Date: 2017-01-22 02:14:35
Also in:
linux-clk, linux-devicetree, linux-gpio
quoted
quoted
quoted
The reason why we enable these two clks here is in below commit commit a5120e89e7e187a91852896f586876c7a2030804 Author: Peter Chen [off-list ref] Date: Fri Jan 18 10:38:05 2013 +0800 ARM i.MX6: change mxs usbphy clock usageSo can we mark these clks with CLK_IS_CRITICAL flag then instead? Or are they disabled out of the bootloader?Sure, using 'CLK_IS_CRITICAL' should be ok for clks_init_on clocks. But for USBPHY*_GATE, it is only enabled when CONIG_USB_MXC_PHY is true. And another concern is if we need to add CLK_IS_CRITICAL flag toclks_init_on clocks, we may need to add new wrapper function to register these critical clock. It is not very good. Ok so set the critical flag when CONFIG_USB_MXC_PHY is enabled? That isn't too hard to do.
Ok, thanks, I will address this in V3.
quoted
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project