On Mon, Jan 30, 2017 at 9:57 AM, John Garry [off-list ref] wrote:

On 27/01/2017 22:03, Rob Herring wrote:

quoted

On Tue, Jan 24, 2017 at 03:05:23PM +0800, zhichang.yuan wrote:

quoted

Signed-off-by: zhichang.yuan <redacted>
Signed-off-by: Gabriele Paoloni <redacted>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Shouldn't this be Reviewed-by?

The background is that Zhichang is following a sketch of a re-worked driver
from Arnd, which Arnd gave Signed-off-by. But this patch does not follow it
verbatim.

I think this patchset should be resent without Arnd's signature. Or Arnd may
kindly review and say it's ok.

My general recommendation is that whenever authorship  is not 100% obvious,
then the changelog comment should explain in free form who did what. When
you do that, please leave my Signed-off-by intact and put it on top.
You can also (in addition to explaining it in the text) add an
explanantion behind
the address, such as

Signed-off-by: Arnd Bergmann <arnd@arndb.de> # earlier draft

I'll try to get around to do a full review of the series later today.

    Arnd