Hi Chanwoo,

quoted

quoted

quoted

quoted

quoted

+       touchkey at 20 {
+               compatible = "samsung,tm2-touchkey";
+               reg = <0x20>;
+               interrupt-parent = <&gpa3>;
+               interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
+               vcc-supply = <&ldo32_reg>;
+               vdd-supply = <&ldo33_reg>;
+       };
+};
+
 &ldo31_reg {
        regulator-name = "TSP_VDD_1.85V_AP";
        regulator-min-microvolt = <1850000>;

I repiled the touchkey driver against compatible name.
Usually, when developing the device driver, we use the specific h/w name
but in this patch, the touckey dt node uses the h/w board name instead of
original touckhey name.

this should be a device specifically done for the tm2 and we are
not sure who is the manufacturer of the device. In order to not

As I knew, this touchkey was made by Cypress semiconductor.
But, for more correct information, you may try to find it.

The Android Kernel says that this is the cy8cmbr3xxx. I
downloaded the datasheets, but it doesn't have any similarity
with the device. Which means that on tm2 we don't the
cy8cmbr3xxx bot something else that I even doubt comes from
cypress, but I strongly believe it's a dedicated hardware.

Now we have two choices:

1. drop support because we are not 100% sure on the device and
supplier.

2. call it Samsung and provide support anyway as, at the end, it
is a samsung hardware.

With Jaechul we chose option 2.

quoted

assign the device to the wrong manufacturer, we preferred calling
it Samsung as it is in a Samsung device.

As you mentioned, Samsung made not this touchkey device. It is
certainly wrong manufacturer. I have not seen to use the h/w board
name as the peripheral device name.

I don't prefer to use the inaccurate manufacturer and device name.

Eventually, Jaechul can assign the device to cypress, but the
name has to remain tm2-touchkey. Something like this:

	compatible = "cypress,tm2-touchkey";

What do you think?

Andi