Thread (5 messages) flat view 5 messages, 3 authors, 2016-12-08
STALE3571d REVIEWED: 1 (0M)

1 review trailer.

[PATCH] Input: lpc32xx-keys - fix invalid error handling of a requested irq

From: Sylvain Lemieux <hidden>
Date: 2016-12-07 18:13:07
Also in: linux-input

On Mon, 2016-12-05 at 03:47 +0200, Vladimir Zapolskiy wrote:
Semantics of NR_IRQS is different on machines with SPARSE_IRQ option
disabled or enabled, in the latter case IRQs are allocated starting
at least from the value specified by NR_IRQS and going upwards, so
the check of (irq >= NR_IRQ) to decide about an error code returned by
platform_get_irq() is completely invalid, don't attempt to overrule
irq subsystem in the driver.

The change fixes lpc32xx_keys driver initialization on boot:

  lpc32xx_keys 40050000.key: failed to get platform irq
  lpc32xx_keys: probe of 40050000.key failed with error -22

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
---
 drivers/input/keyboard/lpc32xx-keys.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Cosmetic - please update the subject line when doing the commit:
replace " -" by ":" after lpc32xx-keys

Acked-by: Sylvain Lemieux <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help