[PATCH 2/9] ARM: dts: exynos: Add pinctrl sleep state for 542x i2s module
From: Tomasz Figa <hidden>
Date: 2016-12-26 05:39:57
Also in:
linux-gpio, linux-pm, linux-samsung-soc
Hi, 2016-12-23 21:24 GMT+09:00 Marek Szyprowski [off-list ref]:
quoted hunk ↗ jump to hunk
Add a special "sleep" state for Exynos I2S module. This state will be used to let I2S driver to notify pin controller that it is ready for turning power off, so the pin controller can also change its runtime state to suspended and in the result let power domain to turn off. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 11 +++++++++++ arch/arm/boot/dts/exynos5420.dtsi | 3 ++- 2 files changed, 13 insertions(+), 1 deletion(-)diff --git a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi index 3924b4fafe72..52983b6a6859 100644 --- a/arch/arm/boot/dts/exynos5420-pinctrl.dtsi +++ b/arch/arm/boot/dts/exynos5420-pinctrl.dtsi@@ -720,4 +720,15 @@ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>; }; + + i2s0_bus_slp: i2s0-bus-slp { + samsung,pins = "gpz-0", "gpz-1", "gpz-2", "gpz-3", + "gpz-4", "gpz-5", "gpz-6"; + samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>; + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>; + samsung,pin-drv = <EXYNOS5420_PIN_DRV_LV1>; + samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>; + samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
Is it really okay to make all the pins inputs without any pull? Wouldn't this cause them to float until the controller is disabled or this is basically an atomic operation?
+ samsung,off-state;
Is this property documented in the binding description?
quoted hunk ↗ jump to hunk
+ }; };diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi index 832cb56c514e..0a7ecdd4c5de 100644 --- a/arch/arm/boot/dts/exynos5420.dtsi +++ b/arch/arm/boot/dts/exynos5420.dtsi@@ -444,8 +444,9 @@ clock-output-names = "i2s_cdclk0"; #sound-dai-cells = <1>; samsung,idma-addr = <0x03000000>; - pinctrl-names = "default"; + pinctrl-names = "default", "sleep";
Is this state documented in the binding description? Best regards, Tomasz