[PATCH v18 03/15] clocksource/drivers/arm_arch_timer: Improve printk relevant code

Hi Joe,

On 9 December 2016 at 05:10, Joe Perches [off-list ref] wrote:

On Fri, 2016-12-09 at 01:33 +0800, fu.wei at linaro.org wrote:

quoted

From: Fu Wei <redacted>

This patch defines pr_fmt(fmt) for all pr_* functions,
then the pr_* doesn't need to add "arch_timer:" everytime.

trivia:

quoted

diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c

[]

quoted

@@ -966,7 +967,7 @@ static int __init arch_timer_mem_init(struct device_node *np)

      ret = -EINVAL;
      if (!irq) {
-             pr_err("arch_timer: Frame missing %s irq",
+             pr_err("Frame missing %s irq",
                     arch_timer_mem_use_virtual ? "virt" : "phys");
              goto out;
      }

Missing terminating newline

                pr_err("Frame missing %s irq\n",

yes, you are right , will fix it. :-)
Thanks


-- 
Best regards,

Fu Wei
Software Engineer
Red Hat