[PATCHv4 05/10] arm64: Use __pa_symbol for kernel symbols
From: catalin.marinas@arm.com (Catalin Marinas)
Date: 2016-12-06 11:47:15
Also in:
linux-mm, lkml
On Mon, Dec 05, 2016 at 04:50:33PM -0800, Florian Fainelli wrote:
On 11/29/2016 10:55 AM, Laura Abbott wrote:quoted
__pa_symbol is technically the marco that should be used for kernel symbols. Switch to this as a pre-requisite for DEBUG_VIRTUAL which will do bounds checking. As part of this, introduce lm_alias, a macro which wraps the __va(__pa(...)) idiom used a few places to get the alias. Signed-off-by: Laura Abbott <redacted> --- v4: Stop calling __va early, conversion of a few more sites. I decided against wrapping the __p*d_populate calls into new functions since the call sites should be limited. ---quoted
- pud_populate(&init_mm, pud, bm_pmd); + if (pud_none(*pud)) + __pud_populate(pud, __pa_symbol(bm_pmd), PMD_TYPE_TABLE); pmd = fixmap_pmd(addr); - pmd_populate_kernel(&init_mm, pmd, bm_pte); + __pmd_populate(pmd, __pa_symbol(bm_pte), PMD_TYPE_TABLE);Is there a particular reason why pmd_populate_kernel() is not changed to use __pa_symbol() instead of using __pa()? The other users in the arm64 kernel is arch/arm64/kernel/hibernate.c which seems to call this against kernel symbols as well?
create_safe_exec_page() may allocate a pte from the linear map and passes such pointer to pmd_populate_kernel(). The copy_pte() function does something similar. In addition, we have the generic __pte_alloc_kernel() in mm/memory.c using linear addresses. -- Catalin