usb: gadget: udc: atmel: used managed kasprintf

Use devm_kasprintf instead of simple kasprintf to free the allocated memory
when needed.

Suggested-by: Peter Rosin <redacted>
Signed-off-by: Alexandre Belloni <redacted>
---
 drivers/usb/gadget/udc/atmel_usba_udc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 45bc997d0711..aec72fe8273c 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c

@@ -1978,7 +1978,8 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
 			dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
 			goto err;
 		}
-		ep->ep.name = kasprintf(GFP_KERNEL, "ep%d", ep->index);
+		ep->ep.name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "ep%d",
+					     ep->index);
 
 		ep->ep_regs = udc->regs + USBA_EPT_BASE(i);
 		ep->dma_regs = udc->regs + USBA_DMA_BASE(i);

-- 
2.10.2

Le 01/12/2016 ? 11:26, Alexandre Belloni a ?crit :

Use devm_kasprintf instead of simple kasprintf to free the allocated memory
when needed.

Suggested-by: Peter Rosin <redacted>
Signed-off-by: Alexandre Belloni <redacted>

Acked-by: Nicolas Ferre <redacted>

-- 
Nicolas Ferre

From: Alexandre Belloni

Sent: 01 December 2016 10:27
Use devm_kasprintf instead of simple kasprintf to free the allocated memory
when needed.

s/when needed/when the device is freed/

Acually why bother mallocing such a small string at all.
The maximum length is 12 bytes even if 'index' are unrestricted.
 
	David

On 02/12/2016 at 15:59:57 +0000, David Laight wrote :

From: Alexandre Belloni

quoted

Sent: 01 December 2016 10:27
Use devm_kasprintf instead of simple kasprintf to free the allocated memory
when needed.

s/when needed/when the device is freed/

quoted

Suggested-by: Peter Rosin <redacted>
Signed-off-by: Alexandre Belloni <redacted>
---
 drivers/usb/gadget/udc/atmel_usba_udc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 45bc997d0711..aec72fe8273c 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c

@@ -1978,7 +1978,8 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
 			dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
 			goto err;
 		}
-		ep->ep.name = kasprintf(GFP_KERNEL, "ep%d", ep->index);
+		ep->ep.name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "ep%d",
+					     ep->index);

Acually why bother mallocing such a small string at all.
The maximum length is 12 bytes even if 'index' are unrestricted.
 

IIRC, using statically allocated string is failing somewhere is the USB
core but I don't remember all the details.


-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

From: Alexandre Belloni

Sent: 02 December 2016 16:19
On 02/12/2016 at 15:59:57 +0000, David Laight wrote :

quoted

From: Alexandre Belloni

quoted

Sent: 01 December 2016 10:27
Use devm_kasprintf instead of simple kasprintf to free the allocated memory
when needed.

s/when needed/when the device is freed/

quoted

Suggested-by: Peter Rosin <redacted>
Signed-off-by: Alexandre Belloni <redacted>
---
 drivers/usb/gadget/udc/atmel_usba_udc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 45bc997d0711..aec72fe8273c 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c

@@ -1978,7 +1978,8 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
 			dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
 			goto err;
 		}
-		ep->ep.name = kasprintf(GFP_KERNEL, "ep%d", ep->index);
+		ep->ep.name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "ep%d",
+					     ep->index);

Acually why bother mallocing such a small string at all.
The maximum length is 12 bytes even if 'index' are unrestricted.

IIRC, using statically allocated string is failing somewhere is the USB
core but I don't remember all the details.

I can't imagine that changing ep->ep.name from 'char *' to 'char [12]' would
make any difference.

	David

Hi,

David Laight [off-list ref] writes:

From: Alexandre Belloni

quoted

Sent: 02 December 2016 16:19
On 02/12/2016 at 15:59:57 +0000, David Laight wrote :

quoted

From: Alexandre Belloni

quoted

Sent: 01 December 2016 10:27
Use devm_kasprintf instead of simple kasprintf to free the allocated memory
when needed.

s/when needed/when the device is freed/

quoted

Suggested-by: Peter Rosin <redacted>
Signed-off-by: Alexandre Belloni <redacted>
---
 drivers/usb/gadget/udc/atmel_usba_udc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 45bc997d0711..aec72fe8273c 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c

@@ -1978,7 +1978,8 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
 			dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
 			goto err;
 		}
-		ep->ep.name = kasprintf(GFP_KERNEL, "ep%d", ep->index);
+		ep->ep.name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "ep%d",
+					     ep->index);

Acually why bother mallocing such a small string at all.
The maximum length is 12 bytes even if 'index' are unrestricted.

IIRC, using statically allocated string is failing somewhere is the USB
core but I don't remember all the details.

I can't imagine that changing ep->ep.name from 'char *' to 'char [12]' would
make any difference.

the actual name is managed by the UDC. Meaning, ep->ep.name should be a
pointer, but it could very well just point to ep->name which would be
char [12].

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170116/9893a195/attachment.sig>

On 16/01/2017 at 12:27:04 +0200, Felipe Balbi wrote :

Hi,

David Laight [off-list ref] writes:

quoted

From: Alexandre Belloni

quoted

Sent: 02 December 2016 16:19
On 02/12/2016 at 15:59:57 +0000, David Laight wrote :

quoted

From: Alexandre Belloni

quoted

Sent: 01 December 2016 10:27
Use devm_kasprintf instead of simple kasprintf to free the allocated memory
when needed.

s/when needed/when the device is freed/

quoted

Suggested-by: Peter Rosin <redacted>
Signed-off-by: Alexandre Belloni <redacted>
---
 drivers/usb/gadget/udc/atmel_usba_udc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 45bc997d0711..aec72fe8273c 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c

@@ -1978,7 +1978,8 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
 			dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
 			goto err;
 		}
-		ep->ep.name = kasprintf(GFP_KERNEL, "ep%d", ep->index);
+		ep->ep.name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "ep%d",
+					     ep->index);

Acually why bother mallocing such a small string at all.
The maximum length is 12 bytes even if 'index' are unrestricted.

IIRC, using statically allocated string is failing somewhere is the USB
core but I don't remember all the details.

I can't imagine that changing ep->ep.name from 'char *' to 'char [12]' would

6 more quoted lines

Yeah, I sent a patch that did just that.
http://lists.infradead.org/pipermail/linux-arm-kernel/2017-January/478602.html

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Hi,

Alexandre Belloni [off-list ref] writes:

quoted

David Laight [off-list ref] writes:

quoted

From: Alexandre Belloni

quoted

Sent: 02 December 2016 16:19
On 02/12/2016 at 15:59:57 +0000, David Laight wrote :

quoted

From: Alexandre Belloni

quoted

Sent: 01 December 2016 10:27
Use devm_kasprintf instead of simple kasprintf to free the allocated memory
when needed.

s/when needed/when the device is freed/

quoted

Suggested-by: Peter Rosin <redacted>
Signed-off-by: Alexandre Belloni <redacted>
---
 drivers/usb/gadget/udc/atmel_usba_udc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 45bc997d0711..aec72fe8273c 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c

@@ -1978,7 +1978,8 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
 			dev_err(&pdev->dev, "of_probe: name error(%d)\n", ret);
 			goto err;
 		}
-		ep->ep.name = kasprintf(GFP_KERNEL, "ep%d", ep->index);
+		ep->ep.name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "ep%d",
+					     ep->index);

Acually why bother mallocing such a small string at all.
The maximum length is 12 bytes even if 'index' are unrestricted.

IIRC, using statically allocated string is failing somewhere is the USB
core but I don't remember all the details.

I can't imagine that changing ep->ep.name from 'char *' to 'char [12]' would
make any difference.

the actual name is managed by the UDC. Meaning, ep->ep.name should be a

6 more quoted lines

it's in my fixes now :-)

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170116/8307cc5b/attachment.sig>