Thread (15 messages) 15 messages, 4 authors, 2016-11-06

[Bug] ARM: mxs: STI: console can't wake up from freeze

From: Daniel Lezcano <hidden>
Date: 2016-11-06 14:55:06
Also in: linux-pm

On 06/11/2016 11:20, Stefan Wahren wrote:
Hi,
quoted
Russell King - ARM Linux [off-list ref] hat am 5. November 2016 um
19:05 geschrieben:


On Sat, Nov 05, 2016 at 04:28:37PM +0100, Stefan Wahren wrote:
quoted
As i wrote in my email before, i added a pr_info() into freeze_wake.
But i never see the output of this message. So i assume freeze_wake
is never called. Again, how could this happen?
Hmm, so the bit that you're getting stuck on is:

        wait_event(suspend_freeze_wait_head,
                   suspend_freeze_state == FREEZE_STATE_WAKE);
thanks for all the feedback. The real cause for this issue is in the irqchip
driver. I fixed it with this patch:
Mind to give some details ?

quoted hunk ↗ jump to hunk
diff --git a/drivers/irqchip/irq-mxs.c b/drivers/irqchip/irq-mxs.c
index 1730470..05fa9f7 100644
--- a/drivers/irqchip/irq-mxs.c
+++ b/drivers/irqchip/irq-mxs.c
@@ -131,12 +131,16 @@ static void asm9260_unmask_irq(struct irq_data *d)
 	.irq_ack = icoll_ack_irq,
 	.irq_mask = icoll_mask_irq,
 	.irq_unmask = icoll_unmask_irq,
+	.flags = IRQCHIP_MASK_ON_SUSPEND |
+		 IRQCHIP_SKIP_SET_WAKE,
 };
 
 static struct irq_chip asm9260_icoll_chip = {
 	.irq_ack = icoll_ack_irq,
 	.irq_mask = asm9260_mask_irq,
 	.irq_unmask = asm9260_unmask_irq,
+	.flags = IRQCHIP_MASK_ON_SUSPEND |
+		 IRQCHIP_SKIP_SET_WAKE,
 };
 
 asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)

-- 
 <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help