[PATCH 3/4] crypto: arm64/aes-ce-ccm - fix decrypt path with new skcipher interface
From: Ard Biesheuvel <hidden>
Date: 2016-11-29 13:05:44
Also in:
linux-crypto
Subsystem:
arm64 port (aarch64 architecture), the rest · Maintainers:
Catalin Marinas, Will Deacon, Linus Torvalds
The new skcipher walk interface does not take into account whether we are encrypting or decrypting. In the latter case, the walk should disregard the MAC. Fix this in the arm64 CE driver. Signed-off-by: Ard Biesheuvel <redacted> --- arch/arm64/crypto/aes-ce-ccm-glue.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/crypto/aes-ce-ccm-glue.c b/arch/arm64/crypto/aes-ce-ccm-glue.c
index d4f35685363b..1a011d658387 100644
--- a/arch/arm64/crypto/aes-ce-ccm-glue.c
+++ b/arch/arm64/crypto/aes-ce-ccm-glue.c@@ -204,10 +204,10 @@ static int ccm_decrypt(struct aead_request *req) struct skcipher_walk walk; u8 __aligned(8) mac[AES_BLOCK_SIZE]; u8 buf[AES_BLOCK_SIZE]; - u32 len = req->cryptlen - authsize; int err; - err = ccm_init_mac(req, mac, len); + req->cryptlen -= authsize; + err = ccm_init_mac(req, mac, req->cryptlen); if (err) return err;
@@ -242,8 +242,7 @@ static int ccm_decrypt(struct aead_request *req) return err; /* compare calculated auth tag with the stored one */ - scatterwalk_map_and_copy(buf, req->src, - req->assoclen + req->cryptlen - authsize, + scatterwalk_map_and_copy(buf, req->src, req->assoclen + req->cryptlen, authsize, 0); if (crypto_memneq(mac, buf, authsize))
--
2.7.4