[PATCH 4/6] ARM: dts: Add clock provider specific properties to max8997 node
From: Javier Martinez Canillas <hidden>
Date: 2016-11-07 15:07:32
Also in:
linux-devicetree, linux-samsung-soc
Hello Pankaj, On 11/07/2016 07:09 AM, Pankaj Dubey wrote:
quoted hunk
This patch adds a label and #clock-cells property to device node of max8997 PMIC to allow using it as a clock provider. CC: Rob Herring <robh+dt@kernel.org> CC: devicetree at vger.kernel.org Signed-off-by: Pankaj Dubey <redacted> --- arch/arm/boot/dts/exynos4210-origen.dts | 3 ++- arch/arm/boot/dts/exynos4210-trats.dts | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-)diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts index cb3a255..6c7ef4e 100644 --- a/arch/arm/boot/dts/exynos4210-origen.dts +++ b/arch/arm/boot/dts/exynos4210-origen.dts@@ -147,11 +147,12 @@ pinctrl-0 = <&i2c0_bus>; pinctrl-names = "default"; - max8997_pmic at 66 { + max8997: max8997_pmic at 66 {
The ePAPR says that the node name should be "somewhat generic, reflecting
the function of the device and not its precise programming model". So I
think this should be instead:
max8997: pmic at 66 {
[...]
- max8997_pmic at 66 {
+ max8997: max8997_pmic at 66 {Same here. The rest looks good to me. Reviewed-by: Javier Martinez Canillas <redacted> Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America