On 2016?11?12? 12:22, Shawn Lin wrote:

On 2016/11/9 21:21, Caesar Wang wrote:

quoted

From: Ziyuan Xu <redacted>

Control power domain for eMMC via genpd to reduce power consumption.

Signed-off-by: Elaine Zhang <redacted>
Signed-off-by: Ziyuan Xu <redacted>
Signed-off-by: Caesar Wang <redacted>

It was verified on my rk3399 evb with kernel4.4, so
free feel to add my tag,

Tested-by: Shawn Lin <shawn.lin@rock-chips.com>

Thanks the tests.

BTW, it seems my reply is bounced form Yakir's address, so please
remove him from CC list if he changed his mail address.

Right, Yakir's (ykk at rock-chips.com) address had left this world.;-)
But the patman tool is auto sending with the Cc people.

-
Caesar

quoted

---

Changes in v2:
- Reviewed-on: https://chromium-review.googlesource.com/376558
- Verified on ChromeOS kernel4.4

arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi 

b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
index cbb7f8b..b401176 100644

--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi

@@ -269,6 +269,7 @@

#clock-cells = <0>;
phys = <&emmc_phy>;
phy-names = "phy_arasan";
+ power-domains = <&power RK3399_PD_EMMC>;
status = "disabled";
};

@@ -690,6 +691,11 @@

status = "disabled";
};

+ qos_emmc: qos at ffa58000 {
+ compatible = "syscon";
+ reg = <0x0 0xffa58000 0x0 0x20>;
+ };
+
qos_gmac: qos at ffa5c000 {
compatible = "syscon";
reg = <0x0 0xffa5c000 0x0 0x20>;

@@ -823,6 +829,11 @@

};

/* These power domains are grouped by VD_LOGIC */
+ pd_emmc at RK3399_PD_EMMC {
+ reg = <RK3399_PD_EMMC>;
+ clocks = <&cru ACLK_EMMC>;
+ pm_qos = <&qos_emmc>;
+ };
pd_gmac at RK3399_PD_GMAC {
reg = <RK3399_PD_GMAC>;
clocks = <&cru ACLK_GMAC>;

-- 
caesar wang | software engineer | wxt at rock-chip.com