On Thu, 2016-11-03 at 13:47 +0100, Hans Verkuil wrote:

Hi Vincent,

On 28/10/16 09:52, Vincent Stehl? wrote:

quoted

On Thu, Oct 27, 2016 at 10:23:24PM +0200, Vincent Stehl? wrote:

quoted

video_device_release() takes a pointer to struct video_device as argument.
Fix two call sites where the address of the pointer is passed instead.

Sorry, I messed up: please ignore that "fix". The 0day robot made me
realize this is indeed not a proper fix.

The issue remains, though: we cannot call video_device_release() on the
vdev structure member, as this will in turn call kfree(). Most probably,
vdev needs to be dynamically allocated, or the call to
video_device_release() dropped completely.

I prefer that vdev is dynamically allocated. There are known problems with
embedded video_device structs, so allocating it is preferred.

Minghsiu, can you do that?

Hi Hans,

I just send the patch for this.
https://patchwork.kernel.org/patch/9415007/

Regards,

	Hans

quoted

Sorry for the bad patch.

Best regards,

Vincent.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html