Thread (2 messages) 2 messages, 2 authors, 2016-10-28

[PATCH] Revert "gpio/mvebu: convert to use irq_domain_add_simple()"

From: Gregory CLEMENT <hidden>
Date: 2016-10-27 07:30:35
Also in: linux-gpio

Hi Linus,
 
 On lun., oct. 24 2016, Linus Walleij [off-list ref] wrote:
On Wed, Oct 19, 2016 at 11:03 PM, Jason Gunthorpe
[off-list ref] wrote:
quoted
From 7566f05ac445b652ba7607cc1899fed10fea1c76 Mon Sep 17 00:00:00 2001
From: Jason Gunthorpe <redacted>
Date: Wed, 19 Oct 2016 14:57:45 -0600
Subject: [PATCH] gpio/mvebu: Use irq_domain_add_linear

This fixes the irq allocation in this driver to not print:
 irq: Cannot allocate irq_descs @ IRQ34, assuming pre-allocated
 irq: Cannot allocate irq_descs @ IRQ66, assuming pre-allocated

Which happens because the driver already called irq_alloc_descs()
and so the change to use irq_domain_add_simple resulted in calling
irq_alloc_descs() twice.

Modernize the irq allocation in this driver to use the
irq_domain_add_linear flow directly and eliminate the use of
irq_domain_add_simple/legacy

Fixes: ce931f571b6d ("gpio/mvebu: convert to use irq_domain_add_simple()")
Signed-off-by: Jason Gunthorpe <redacted>
So can I just apply this?
Gregory?
For me it's OK.

Gregory
Yours,
Linus Walleij
-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help