Thread (1 message) 1 message, 1 author, 2016-10-28

[PATCH] fpga: zynq-fpga: Delete not needed variable

From: mbrugger@suse.com (Matthias Brugger)
Date: 2016-10-28 16:39:12
Also in: lkml


On 28/10/16 13:27, Matthias Brugger wrote:
Variable count is never changed in the write path,
we don't need to save it for freeing the dma memory.

Signed-off-by: Matthias Brugger <mbrugger@suse.com>
This is obsolete, as Jason already has this in his patch [1].
Sorry for the noise.

[1] http://www.spinics.net/lists/arm-kernel/msg538868.html
quoted hunk
---
 drivers/fpga/zynq-fpga.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c
index c2fb412..ffc2823 100644
--- a/drivers/fpga/zynq-fpga.c
+++ b/drivers/fpga/zynq-fpga.c
@@ -287,12 +287,10 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr,
 	struct zynq_fpga_priv *priv;
 	int err;
 	char *kbuf;
-	size_t in_count;
 	dma_addr_t dma_addr;
 	u32 transfer_length;
 	u32 intr_status;

-	in_count = count;
 	priv = mgr->priv;

 	kbuf = dma_alloc_coherent(priv->dev, count, &dma_addr, GFP_KERNEL);
@@ -338,7 +336,7 @@ static int zynq_fpga_ops_write(struct fpga_manager *mgr,
 	clk_disable(priv->clk);

 out_free:
-	dma_free_coherent(priv->dev, in_count, kbuf, dma_addr);
+	dma_free_coherent(priv->dev, count, kbuf, dma_addr);

 	return err;
 }
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help